-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layers/meta-opentrons: support pydantic v2 #185
Merged
Merged
+11,554
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from upstream oe-core gatesgarth.
From upstream meta-openembedded
We need this because we need the altered manifest and access to the manifest.json file in the recipe directory is hardcoded in the recipe for some reason.
Or more specifically cargo and everything that depends on, since maturin uses cargo.toml features that need a new version
needed for pydantic-core
We should squash merge this since it doesn't involve git shenanigans |
vegano1
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super big rust dep! but can't be helped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the work to support pydantic v2 as in Opentrons/opentrons#14871.
This is a pretty significant amount because pydantic v2 uses rust and modern python packaging tooling, which our older openembedded does not. So we're borrowing a lot from upstream openembedded-core and meta-openembedded to get a working rust cross setup, and hacking it together a little to support our pipenv installation process.